You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
npm WARN publish npm auto-corrected some errors in your package.json when publishing. Please run "npm pkg fix" to address these errors.
npm WARN publish errors corrected:
npm WARN publish Removed invalid "scripts"
npm WARN publish "repository.url" was normalized to "git+https://github.com/google/blockly.git"
Proposed Changes
Runs npm pkg fix and commits that change -- it doesn't tell me what the "invalid scripts" are but none are removed. fwiw I ran the command in the dist directory too and there already aren't any scripts in that package.json so 🤷♀️
This is a side effect of how npm has been publishing packuments this whole time.
If you inspect the packages in the registry, you'll see they all have an empty scripts object even if the package.json source does not.
The new logging is a byproduct of our attempts to make sure these two entries are in sync. The decision was made to NOT allow a change change to what's in the registry to minimize potential breaking changes for those who consume these packages.
The git+ change is a no-op as far as I can tell. So I don't think this change is necessary, or will resolve the warnings. But approving in case it does.
Thanks for the link! It sounds like we'd need to add an empty scripts property to the package.json file that we generate in dist to completely get rid of the warning, which is dumb (and a misleading warning)
but I'm pretty sure this will at least remove the bit about the url being normalized, and as you said, shouldn't have any other effect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes this warning when publishing:
Proposed Changes
Runs
npm pkg fixand commits that change -- it doesn't tell me what the "invalid scripts" are but none are removed. fwiw I ran the command in thedistdirectory too and there already aren't anyscriptsin that package.json so 🤷♀️Reason for Changes
release follow up
Test Coverage
Documentation
Additional Information